[ResponseOps][Rules]Move uptime rule params to package #205238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
adcoelho
force-pushed
the
move-uptime-rule-params
branch
from
b8fc596 to
f3fa2fa
Compare
shahzad31
approved these changes
Jan 2, 2025
💚 Build Succeeded
Metrics [docs]
History
cc @adcoelho |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
adcoelho
added a commit
to adcoelho/kibana
that referenced
this pull request
Jan 7, 2025
Connected with elastic#195187 - Moved params of duration anomaly rule type to `/response-ops/rule_params/uptime_duration_anomaly/` - Moved params of monitor status rule type to `/response-ops/rule_params/uptime_monitor_status/` - Moved params of TLS rule type to `/response-ops/rule_params/uptime_tls/` - **Did not move anything related to the legacy TLS rule type.** I ran into a similar issue to elastic#205207 for the monitor status rule type. It doesn't block this PR but some follow up work might be needed for `x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`. We will probably decide after the new year. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit c8d46ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
adcoelho
added a commit
that referenced
this pull request
Jan 8, 2025
#205725) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Rules]Move uptime rule params to package (#205238)](#205238) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T12:20:20Z","message":"[ResponseOps][Rules]Move uptime rule params to package (#205238)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n- Moved params of monitor status rule type to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved params of TLS rule type to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move anything related to the legacy TLS rule type.**\r\n\r\nI ran into a similar issue to #205207 for the monitor status rule type.\r\nIt doesn't block this PR but some follow up work might be needed for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe will probably decide after the new year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport missing","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"number":205238,"url":"https://github.com/elastic/kibana/pull/205238","mergeCommit":{"message":"[ResponseOps][Rules]Move uptime rule params to package (#205238)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n- Moved params of monitor status rule type to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved params of TLS rule type to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move anything related to the legacy TLS rule type.**\r\n\r\nI ran into a similar issue to #205207 for the monitor status rule type.\r\nIt doesn't block this PR but some follow up work might be needed for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe will probably decide after the new year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205238","number":205238,"mergeCommit":{"message":"[ResponseOps][Rules]Move uptime rule params to package (#205238)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n- Moved params of monitor status rule type to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved params of TLS rule type to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move anything related to the legacy TLS rule type.**\r\n\r\nI ran into a similar issue to #205207 for the monitor status rule type.\r\nIt doesn't block this PR but some follow up work might be needed for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe will probably decide after the new year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added
v8.18.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
Connected with elastic#195187 ## Summary - Moved params of duration anomaly rule type to `/response-ops/rule_params/uptime_duration_anomaly/` - Moved params of monitor status rule type to `/response-ops/rule_params/uptime_monitor_status/` - Moved params of TLS rule type to `/response-ops/rule_params/uptime_tls/` - **Did not move anything related to the legacy TLS rule type.** I ran into a similar issue to elastic#205207 for the monitor status rule type. It doesn't block this PR but some follow up work might be needed for `x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`. We will probably decide after the new year. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected with #195187
Summary
/response-ops/rule_params/uptime_duration_anomaly//response-ops/rule_params/uptime_monitor_status//response-ops/rule_params/uptime_tls/I ran into a similar issue to #205207 for the monitor status rule type. It doesn't block this PR but some follow up work might be needed for
x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts. We will probably decide after the new year.